Remove Config Values as Env var in API server

Move these config to configmap so that changing configmap configures the value.
tektoncd · Jan 29, 2024 · ed1ffdb · ed1ffdb
1 parent 456ba20
commit ed1ffdb
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 38 deletions.
diff --git a/config/base/api.yaml b/config/base/api.yaml
@@ -46,8 +46,6 @@ spec:
                 secretKeyRef:
                   name: tekton-results-postgres
                   key: POSTGRES_PASSWORD
-            - name: DB_NAME
-              value: tekton-results
           volumeMounts:
             - name: config
               mountPath: /etc/tekton/results

diff --git a/config/base/env/config b/config/base/env/config
@@ -1,8 +1,8 @@
 DB_USER=
 DB_PASSWORD=
-DB_HOST=
+DB_HOST=tekton-results-postgres-service.tekton-pipelines.svc.cluster.local
 DB_PORT=5432
-DB_NAME=
+DB_NAME=tekton-results
 DB_SSLMODE=disable
 DB_SSLROOTCERT=
 DB_ENABLE_AUTO_MIGRATION=true

diff --git a/config/components/local-db/api.yaml b/config/components/local-db/api.yaml
diff --git a/config/components/local-db/kustomization.yaml b/config/components/local-db/kustomization.yaml
@@ -21,9 +21,3 @@ kind: Component
 
 resources:
 - 201-sql-deployment.yaml
-
-patches:
-- target:
-    kind: Deployment
-    name: api
-  path: api.yaml
diff --git a/test/e2e/gcs-emulator.yaml b/test/e2e/gcs-emulator.yaml
@@ -72,9 +72,9 @@ data:
   config: |
     DB_USER=
     DB_PASSWORD=
-    DB_HOST=
+    DB_HOST=tekton-results-postgres-service.tekton-pipelines.svc.cluster.local
     DB_PORT=5432
-    DB_NAME=
+    DB_NAME=tekton-results
     DB_SSLMODE=disable
     DB_ENABLE_AUTO_MIGRATION=true
     SERVER_PORT=8080