Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the TSP examples from TSB with Toolkit configs #60

Merged
merged 10 commits into from
Jul 16, 2024

Conversation

esarver
Copy link
Member

@esarver esarver commented Jul 5, 2024

Pull Request Checklist

Please review the Contribution Guidelines before submitting.

  • You have previously submitted a Contributor License Agreement or have contacted a maintainer to request one.
  • You have given the Pull Request a descriptive name above.
  • You placed all files in an appropriate directory.
  • You updated README files if placing files in directories that already have READMEs.

Type (Select only one)

  • Bug fix
  • Working example
  • In-progress example (need Keithley help)
  • In-progress example (do not need Keithley help)

Description

  • Move the TSP examples from TSB to this repository
  • Add TSP Toolkit config file to each example directory so it is preconfigured.

@esarver esarver added the enhancement New feature or request label Jul 5, 2024
@esarver esarver self-assigned this Jul 5, 2024
@esarver
Copy link
Member Author

esarver commented Jul 8, 2024

@Brad-O and/or @Little-LIZard: Please pull this down a spot check a few of the folders to make sure that you aren't getting undefined errors. I noticed that there is an absolute path to my extensions folder in the .vscode/settings.json file. I just want to make sure it gets replaced when you open one of those folders (I'm not really concerned with the path being present in general).

I expect "undefined" errors for the following as they are not yet supported by TSP Toolkit:

  • DAQ6510
  • DMM6500
  • 2601B-PULSE
  • 2651A
  • 2657A
  • 3706A
  • 70xB

@Brad-O
Copy link
Collaborator

Brad-O commented Jul 8, 2024

Thanks @esarver! I'll take a look this week.

Copy link
Collaborator

@Brad-O Brad-O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Brad-O Brad-O merged commit bb7548b into main Jul 16, 2024
7 checks passed
@Brad-O Brad-O deleted the esarver/add_tsb_examples branch July 16, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants