Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/add trust store to ssl context mongo driver options #2388

Merged

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Jun 26, 2024

Continuation of PR #2386

@AlvaroVega AlvaroVega marked this pull request as ready for review June 26, 2024 14:43
@AlvaroVega AlvaroVega requested a review from fgalan June 26, 2024 14:53
Comment on lines +327 to +328
| mongo\_ssl\_truststore\_path\_file | no | <i>empty</i> | Java SSL TrustStore for CAs path file (JKS file). |
| mongo\_ssl\_truststore\_password | no | <i>empty</i> | Java SSL TrustStore password for keystore file (JKS file). |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be added to CNR entry?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 3356903

Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit f2f771d into master Jun 26, 2024
7 checks passed
@fgalan fgalan deleted the task/add_trustStore_to_ssl_context_mongo_driver_options branch June 26, 2024 15:40
This was referenced Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants