Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

constants.DEFAULT_ATTRIBUTE_TYPE is string instead of Text #810

Closed
AlvaroVega opened this issue Jan 30, 2024 · 3 comments
Closed

constants.DEFAULT_ATTRIBUTE_TYPE is string instead of Text #810

AlvaroVega opened this issue Jan 30, 2024 · 3 comments

Comments

@AlvaroVega
Copy link
Member

Component

Techdeb

Is your feature request related to a problem? Please describe

Used by

function guessType(attribute, device, measureType) {
if (device.active) {
for (let i = 0; i < device.active.length; i++) {
if (device.active[i].name === attribute) {
return device.active[i].type;
}
}
}
if (attribute === constants.TIMESTAMP_ATTRIBUTE) {
return constants.TIMESTAMP_TYPE_NGSI2;
}
if (measureType) {
return measureType;
} else {
return constants.DEFAULT_ATTRIBUTE_TYPE;
}
}

Describe the solution you'd like

It should be Text, which is the default type for NGSI

Describe alternatives you've considered

No response

The systemd version you checked that didn't have the feature you are asking for

No response

@fgalan
Copy link
Member

fgalan commented Jan 30, 2024

It should be Text, which is the default type for NGSI

Ref: https://github.com/telefonicaid/fiware-orion/blob/master/doc/manuals/orion-api.md#partial-representations

@KeshavSoni2511
Copy link
Contributor

Hi @fgalan @AlvaroVega, I would like to contribute on this issue.

@fgalan
Copy link
Member

fgalan commented Feb 1, 2024

Fixed by PR #813

@fgalan fgalan closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants