Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prelanding/fix binary data #760

Merged
merged 17 commits into from
Oct 6, 2023
Merged

Prelanding/fix binary data #760

merged 17 commits into from
Oct 6, 2023

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Oct 3, 2023

contribution from #736 by @Keshav-NEC

Co-authored-by: Alvaro Vega <alvaro.vegagarcia@telefonica.com>
Copy link
Collaborator

@mapedraza mapedraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlvaroVega AlvaroVega marked this pull request as ready for review October 6, 2023 12:19
@fgalan
Copy link
Member

fgalan commented Oct 6, 2023

Discussing this with @mapedraza we think it would be great to include documentation in this PR (at the present moment, it seems this is not document at all).

@mapedraza
Copy link
Collaborator

Discussing this with @mapedraza we think it would be great to include documentation in this PR (at the present moment, it seems this is not document at all).

Addressed in a03ac1a

docs/usermanual.md Outdated Show resolved Hide resolved
mapedraza and others added 2 commits October 6, 2023 15:39
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 18d3568 into master Oct 6, 2023
7 checks passed
@fgalan fgalan deleted the prelanding/fix-binary-data branch October 6, 2023 13:46
@AlvaroVega AlvaroVega mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants