-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send update for multiple measures #826
Conversation
Functional tests (which I think "live" in the iotagent-node-lib repository) should be expanded to take into account the new functionality? @mapedraza what do you think? |
It seems it has been taken into account (see telefonicaid/iotagent-node-lib#1607 (comment)) |
The test was added in |
Similar PR for iotagent-ul should be implemented? |
I think so, so the IOTAs keep synced in functionality. |
Not sure if iotagent-ul is able to receive multiple measures at the same time, due to UL protocol format https://github.com/telefonicaid/iotagent-ul/blob/master/docs/usermanual.md#ultralight-20-protocol |
Documentation at https://github.com/telefonicaid/iotagent-ul/blob/master/docs/usermanual.md#measure-payload-syntax describes multimeasure support:
(The last part of the documentation should be adjusted after the implementation of the new functionality to something like this: "This will generate two elements in the NGSI batch update request ( |
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
Done twin PR in telefonicaid/iotagent-ul#677 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix for #825
and needs telefonicaid/iotagent-node-lib#1607