Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add response time procesing header #845

Merged
merged 11 commits into from
Sep 27, 2024

Conversation

AlvaroVega
Copy link
Member

@AlvaroVega AlvaroVega commented Sep 23, 2024

telefonicaid/iotagent-node-lib#1650

Usage:
$ curl -i -X POST 'http://localhost:7897/iot/json?i=disp1&k=APIKEY1' -d '{ "level": "33"}' -H 'content-type: application/json'
HTTP/1.1 200 OK
X-Powered-By: Express
X-Processing-Time: 38
Content-Type: application/json; charset=utf-8
Content-Length: 2
ETag: W/"2-vyGp6PvFo4RvsFtPoIWeCReyIC8"
Date: Thu, 26 Sep 2024 11:28:57 GMT
Connection: keep-alive
Keep-Alive: timeout=5

@AlvaroVega AlvaroVega requested a review from fgalan September 26, 2024 08:26
@@ -521,6 +524,11 @@ Content-type: application/json
}
```

#### Time processing

HTTP bindig is returning in a HTTP header named `X-Processing-Time` processing time expended by current HTTP measure
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which unit is provide (seconds, etc.)? Are decimal allowed?

Including an example would be great.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated doc: 4e05442

CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
CHANGES_NEXT_RELEASE Outdated Show resolved Hide resolved
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan
Copy link
Member

fgalan commented Sep 27, 2024

Twin PR telefonicaid/iotagent-ul#685

@fgalan fgalan merged commit e50e105 into master Sep 27, 2024
5 of 7 checks passed
@fgalan fgalan deleted the task/add_response_header_procesing_time branch September 27, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants