Merge pull request #1511 from cblancog00/master

[FIX][ISSUE 1510] Solve failed authentication when using user and pas…
telefonicaid · Oct 11, 2023 · 21c0081 · 21c0081
2 parents 0d1ae90 + d65634c
commit 21c0081
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/CHANGES_NEXT_RELEASE b/CHANGES_NEXT_RELEASE
@@ -1,3 +1,4 @@
+- Fix: MongoDB connection authentication (user and password were not actually used) (#1510)
 - Fix: add static attributes when use explicitAttrs (#1506)
 - Remove: single configuration mode (along with IOTA_SINGLE_MODE env var) (#1469)
 - Remove: extractVariables from jexl plugin (no needed anymore since the removal of bidireational plugin)

diff --git a/lib/model/dbConn.js b/lib/model/dbConn.js
@@ -72,9 +72,15 @@ function init(host, db, port, options, callback) {
         return previous;
     }
 
+    url = 'mongodb://';
+
+    if (options.auth) {
+        url += options.auth.user + ':' + options.auth.password + '@';
+    }
+
     const hosts = host.split(',').map(addPort).reduce(commaConcat, '');
 
-    url = 'mongodb://' + hosts + '/' + db;
+    url += hosts + '/' + db;
 
     if (options.extraArgs) {
         if (options.extraArgs instanceof Object && Object.keys(options.extraArgs).length > 0) {

diff --git a/test/unit/mongodb/mongodb-connectionoptions-test.js b/test/unit/mongodb/mongodb-connectionoptions-test.js
@@ -154,7 +154,7 @@ describe('dbConn.configureDb', function () {
                     password: 'pass01'
                 },
                 expected: {
-                    url: 'mongodb://example.com:27017/' + dbConn.DEFAULT_DB_NAME,
+                    url: 'mongodb://user01:pass01@example.com:27017/' + dbConn.DEFAULT_DB_NAME,
                     options: {
                         auth: {
                             user: 'user01',
@@ -190,7 +190,7 @@ describe('dbConn.configureDb', function () {
                     authSource: 'admin'
                 },
                 expected: {
-                    url: 'mongodb://example.com:98765/examples',
+                    url: 'mongodb://user01:pass01@example.com:98765/examples',
                     options: {
                         replicaSet: 'rs0',
                         auth: {
@@ -308,7 +308,7 @@ describe('dbConn.configureDb', function () {
                     unknownparam: 'unknown'
                 },
                 expected: {
-                    url: 'mongodb://example.com:98765/examples?retryWrites=true&readPreference=nearest&w=majority',
+                    url: 'mongodb://user01:pass01@example.com:98765/examples?retryWrites=true&readPreference=nearest&w=majority',
                     options: {
                         replicaSet: 'rs0',
                         auth: {