[Do not merge] New config groups API endpoint #1637

mapedraza · 2024-08-07T08:07:14Z

Issue #752
Overpasses #1375

Pending:

Just some minor improvements points:

1): I can't see tests implementing cross functionality. I mean, creating groups using services and then retrieving it through configGroup endpoint. It should be aded in both ways, I mean, creating as services and configGroup and retrieving them with the opposite.
2) In order to configure the keyword used by the new endpoint, it would be great if instead of having a magic word, it is moved to the constans file (lib/constants.js), replacing each time in the code appears 'configgroups'. It should be configured for the API route and for the term used in the json response.

Check before merging:

Modify just merged doc/getting-started.md to use the new API (Done here: cdb791c)

…t.js Co-authored-by: mapedraza <40356341+mapedraza@users.noreply.github.com>

Merge remote-tracking branch 'upstream/master' into Added_Feature_ConfigGroups

Line 62 removed and rebased

…Groups

Added feature config groups

mapedraza · 2024-08-08T13:33:28Z

Commit aa64573 solves pending point 2:

In order to configure the keyword used by the new endpoint, it would be great if instead of having a magic word, it is moved to the constans file (lib/constants.js), replacing each time in the code appears 'configgroups'. It should be configured for the API route and for the term used in the json response.

Tests use a constants strings (http://localhost:4041/iot/configGroups) instead of a parameter (constants.CONFIGGROUP_TERM) to be more legible

mapedraza · 2024-08-09T08:33:01Z

Commit 0b38688 solves pending point 1):

1): I can't see tests implementing cross functionality. I mean, creating groups using services and then retrieving it through configGroup endpoint. It should be aded in both ways, I mean, creating as services and configGroup and retrieving them with the opposite.

AlvaroVega · 2024-08-09T08:38:25Z

package-lock.json

This file should not be part of repository.

Removed in e2ea6c2
Added to gitignore here: d48cc4b

AlvaroVega · 2024-08-09T08:39:22Z

test/unit/examples/groupProvisioningRequests/bidirectionalConfigGroup.json

Bidirectional feature was not removed on previous PRs ?

Added this PR with more leftovers: #1644

Once it gets merged, this PR should be sync

Done in: 611b45f

fgalan · 2024-08-09T08:49:03Z

CHANGES_NEXT_RELEASE

@@ -3,4 +3,5 @@
 - Fix: service header to use uppercase in case of update and delete (#1528)
 - Fix: Allow to send to CB batch update for multimeasures for NGSI-LD (#1623)
 - Add: new JEXL transformations for including into an array keys that have a certain value: valuePicker and valuePickerMulti
+- Add /iot/configGroups API endpoints (as equivalent to /iot/services) (#752)


Suggested change

- Add /iot/configGroups API endpoints (as equivalent to /iot/services) (#752)

- Add /iot/configGroups API endpoints (as equivalent to /iot/services) (#752)

- Deprecated: /iot/services API routes

Added here:e1f4e47

This commit also includes an entry in deprecated.md file

fgalan · 2024-08-09T08:54:23Z

doc/api.md

@@ -1847,11 +1850,11 @@ _**Response headers**_

 Successful operations return `Content-Type` header with `application/json` value.

-#### Modify config group `PUT /iot/services`
+#### Modify config group `PUT /iot/configGroups` or `PUT /iot/services`


I'd suggest to remove references to /iot/services in any file, as it is deprecated feature and, as stated in doc

Documentation on deprecated features is removed from the repository documentation. Documentation is still available in the documentation set associated to older versions (in the repository release branches).

Pending to choose the final term for configGroups

fgalan · 2024-08-12T07:30:08Z

doc/deprecated.md

+-   Services API routes (`/iot/services`) in favor of the `/iot/configGroups`. Both are still supported, but the former
+    is deprecated.


Suggested change

- Services API routes (`/iot/services`) in favor of the `/iot/configGroups`. Both are still supported, but the former

is deprecated.

- Services API routes (`/iot/services`) in favor of the `/iot/configGroups`.

Looking the above elements, it is assumed that every deprecated feature is still supported, except the ones with the "(finally removed in x)" part.

AlvaroVega

LGTM

mrutid · 2024-08-23T08:39:57Z

lib/fiware-iotagent-lib.js

+            })
+        ],
+        callback
+    );


try to avoid "Linter changes" not corresponding to current PR.

fgalan · 2024-08-23T09:44:54Z

After @mrutid @mapedraza @fgalan discussion today, this PR is going to be re-worked.

mapedraza · 2024-08-26T13:12:51Z

overpassed by #1648

root and others added 23 commits May 22, 2023 09:51

Fix_for_nodelib_issue_752

4aa64c5

Fix for issue 752

1016def

Document improvements for issue 752

ab1d728

Syncing with master

0b0973d

Rebase

1ea983f

Update deviceConfigGroup.json

5c686c0

Update deviceService-test.js

5899a2b

Update test/unit/ngsiv2/provisioning/singleGroupConfigurationMode-tes…

a4db57a

…t.js Co-authored-by: mapedraza <40356341+mapedraza@users.noreply.github.com>

Latest Changes

4fad7ea

Latest Changes

a07215c

Rebased

207cbb5

ChangeAccToMaster

5174f01

Rebased

92340d4

Rebased and latest changes done

2abd610

Rebased

06bcc74

Remove_Code_Duplicacy

7483358

q

c0100be

Merge remote-tracking branch 'upstream/master' into Added_Feature_ConfigGroups

FixLintError

8f91d13

Update groupService.js

1178705

Line 62 removed and rebased

Rebased_with_latest_changes

7320d9a

Rebased and resolved conflicts

407c156

Merge branch 'prelanding/new-config-groups' into Added_Feature_Config…

bc1a1d4

…Groups

Merge pull request #1375 from KeshavSoni2511/Added_Feature_ConfigGroups

e53d004

Added feature config groups

mapedraza changed the title ~~New config groups API endpoint~~ [WIP] New config groups API endpoint Aug 7, 2024

fgalan mentioned this pull request Aug 7, 2024

[Doc] Change the term services group to groups #1632

Closed

magickey to constant

aa64573

mapedraza added 3 commits August 8, 2024 15:38

Merge branch 'master' into prelanding/new-config-groups

d69f338

Fix lint

9e25475

Add cross usage tests

0b38688

mapedraza changed the title ~~[WIP] New config groups API endpoint~~ New config groups API endpoint Aug 9, 2024

AlvaroVega reviewed Aug 9, 2024

View reviewed changes

fgalan reviewed Aug 9, 2024

View reviewed changes

mapedraza and others added 5 commits August 9, 2024 12:23

remove package-lock.json

e2ea6c2

Add package-lock to gitignore

d48cc4b

Add deprecation message

e1f4e47

Merge branch 'master' into prelanding/new-config-groups

5a423a8

remove bidirectional leftover file

611b45f

fgalan reviewed Aug 12, 2024

View reviewed changes

AlvaroVega approved these changes Aug 20, 2024

View reviewed changes

fgalan mentioned this pull request Aug 21, 2024

Modify getting started to use IoTA JSON #1646

Merged

mapedraza and others added 3 commits August 23, 2024 09:10

replace configGroups to groups

ceafc78

Merge branch 'master' into prelanding/new-config-groups

c9b95e5

replace group API endpoint

cdb791c

mrutid reviewed Aug 23, 2024

View reviewed changes

lib/fiware-iotagent-lib.js

})

],

callback

);

Copy link

Member

mrutid Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to avoid "Linter changes" not corresponding to current PR.

mapedraza changed the title ~~New config groups API endpoint~~ [Do no merge] New config groups API endpoint Aug 23, 2024

mapedraza changed the title ~~[Do no merge] New config groups API endpoint~~ [Do not merge] New config groups API endpoint Aug 23, 2024

mapedraza mentioned this pull request Aug 23, 2024

Add new /iot/groups API route #1648

Merged

3 tasks

mapedraza closed this Aug 26, 2024

mapedraza mentioned this pull request Aug 26, 2024

Add /iot/groups routes to manager telefonicaid/iotagent-manager#270

Closed

fgalan deleted the prelanding/new-config-groups branch August 26, 2024 14:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Do not merge] New config groups API endpoint #1637

[Do not merge] New config groups API endpoint #1637

mapedraza commented Aug 7, 2024 •

edited

Loading

mapedraza commented Aug 8, 2024

mapedraza commented Aug 9, 2024

AlvaroVega Aug 9, 2024

mapedraza Aug 9, 2024

AlvaroVega Aug 9, 2024

mapedraza Aug 9, 2024

mapedraza Aug 9, 2024

fgalan Aug 9, 2024

mapedraza Aug 9, 2024

fgalan Aug 9, 2024

mapedraza Aug 9, 2024

fgalan Aug 12, 2024

AlvaroVega left a comment

mrutid Aug 23, 2024

fgalan commented Aug 23, 2024

mapedraza commented Aug 26, 2024

	- Add /iot/configGroups API endpoints (as equivalent to /iot/services) (#752)
	- Add /iot/configGroups API endpoints (as equivalent to /iot/services) (#752)
	- Deprecated: /iot/services API routes

		- Services API routes (`/iot/services`) in favor of the `/iot/configGroups`. Both are still supported, but the former
		is deprecated.

[Do not merge] New config groups API endpoint #1637

[Do not merge] New config groups API endpoint #1637

Conversation

mapedraza commented Aug 7, 2024 • edited Loading

mapedraza commented Aug 8, 2024

mapedraza commented Aug 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlvaroVega left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fgalan commented Aug 23, 2024

mapedraza commented Aug 26, 2024

mapedraza commented Aug 7, 2024 •

edited

Loading