Add new /iot/groups API route
#1648
Conversation
mapedraza
changed the title
/iot/groups API route/iot/groups API route
| '/iot/services', | ||
| restUtils.checkRequestAttributes('headers', mandatoryHeaders), | ||
| restUtils.checkBody(templateGroupService), | ||
| handleCreateDeviceGroup | ||
| ); | ||
|
|
||
| router.post( | ||
| '/iot/groups', | ||
| restUtils.checkRequestAttributes('headers', mandatoryHeaders), | ||
| restUtils.checkBody(templateGroup), | ||
| handleCreateDeviceGroup | ||
| ); |
There was a problem hiding this comment.
Note: Needed 2 router.post() entries in order to allow to use a different template for each query
NTD.
There was a problem hiding this comment.
I got that. Maybe CheckBody should take care of it. If it can do comlex checkings.
There was a problem hiding this comment.
"revalidator" dependency doesn't allow conditional checking. The point here is that limits on auxiliar libs shouldn't drive to special "code structures" at the top level code. Top Level code is more important than a limited validation library. I think uniformity at this level is more important than check two options of JSON (probably this can be achieved by using async.some module already required)
mapedraza
changed the title
/iot/groups API route/iot/groups API route
|
The following should be added to CHANGES_NEXT_RELEASED (as in PR #1637): |
test/unit/ngsiv2/provisioning/device-provisioning-configGroup-api_test.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>
This PR solves #752
This PR overpasses #1637