FRR transition bugfix #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-strusiewiczsurmacki-mobica
force-pushed
the
frr-transition-bugfix
branch
from
eb9ab41
to
23d62c5
Compare
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
p-strusiewiczsurmacki-mobica
force-pushed
the
frr-transition-bugfix
branch
from
3083a9d
to
b3b8aa0
Compare
Cellebyte
requested review from
MaxRink,
Cellebyte,
chdxD1 and
schrej
as code owners
Cellebyte
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #143
I've changed order of FRR configuration. Now the FRR config is created and FRR is reloaded, and then the interfaces are created. This should stop VNI L2 to L3 transition messages in FRR/Zebra.
Additionally, I've added setting already existing interfaces up. This should fix the bug where interfaces were not up after first reconciliation and they don't become up in next reconciliation as only newly created interfaces were processed previously.