Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rabbitmq queue #289

Merged
merged 10 commits into from
Aug 8, 2023
Merged

Rabbitmq queue #289

merged 10 commits into from
Aug 8, 2023

Conversation

kamilernerd
Copy link
Collaborator

No description provided.

Copy link
Member

@sklirg sklirg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments 🧹

sender/rabbitmq_test.go Outdated Show resolved Hide resolved
receiver/rabbitmq.go Outdated Show resolved Hide resolved
receiver/rabbitmq.go Outdated Show resolved Hide resolved
receiver/rabbitmq_test.go Outdated Show resolved Hide resolved
sender/rabbitmq.go Outdated Show resolved Hide resolved
sender/rabbitmq.go Outdated Show resolved Hide resolved
sender/rabbitmq.go Outdated Show resolved Hide resolved
sender/rabbitmq.go Outdated Show resolved Hide resolved
sender/rabbitmq.go Outdated Show resolved Hide resolved
Comment on lines +85 to +86
i := 0
for i < 100000 {
Copy link
Member

@sklirg sklirg Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a typical for-loop instead of while-style:

for i := 0; i <= 100000; i++ {
    ...
}

@KristianLyng KristianLyng merged commit 69e88b4 into primary Aug 8, 2023
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants