-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Voice.pm: #5
Open
troywill
wants to merge
6
commits into
tempire:master
Choose a base branch
from
troywill:tdw-branch
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Voice.pm: #5
Commits on Aug 12, 2013
-
Change "post_form" method to "post" ===================================== The following error was encountered on Monday, August 12, 2013 using Google::Voice version 0.05: ,---- | Can't locate object method "post_form" via package "Mojo::UserAgent" at /home/troy/perl5/lib/perl5/Google/Voice.pm line 41. `---- "post_form" is an obsolete method. See [http://mojolicio.us/perldoc/Mojo/UserAgent#post] for post examples: ,---- | my $tx = $ua->post('example.com'); | my $tx = $ua->post('http://example.com' => {DNT => 1} => 'Hi!'); | my $tx = $ua->post( | 'http://example.com' => {DNT => 1} => form => {a => 'b'}); | my $tx = $ua->post( | 'http://example.com' => {DNT => 1} => json => {a => 'b'}); `---- Here's the line in Voice.pm that causes the errors: ,---- | $c->post_form( | 'https://accounts.google.com/ServiceLogin', | { Email => $user, | Passwd => $pass, | GALX => $galx, | } | ); `---- And here's the modified line: ,---- | $c->post_form( | 'https://accounts.google.com/ServiceLogin', | { Email => $user, | Passwd => $pass, | GALX => $galx, | } | ); `----
Configuration menu - View commit details
-
Copy full SHA for 3d982ed - Browse repository at this point
Copy the full SHA 3d982edView commit details -
Change post_form method in send_sms ===================================== Here's the line in Voice.pm that causes the errors: ,---- | my $json = $c->post_form( | 'https://www.google.com/voice/b/0/sms/send', | { id => undef, | phoneNumber => $phone, | text => $content || '', | _rnr_se => $self->rnr_se | } | )->res->json; `---- And here's the fix: ,---- | my $json = $c->post( | 'https://www.google.com/voice/b/0/sms/send' => form => | { id => undef, | phoneNumber => $phone, | text => $content || '', | _rnr_se => $self->rnr_se | } | )->res->json; `----
Configuration menu - View commit details
-
Copy full SHA for 751e302 - Browse repository at this point
Copy the full SHA 751e302View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b9ccb8 - Browse repository at this point
Copy the full SHA 1b9ccb8View commit details
Commits on Aug 15, 2013
-
Configuration menu - View commit details
-
Copy full SHA for 21aaeda - Browse repository at this point
Copy the full SHA 21aaedaView commit details
Commits on Aug 21, 2013
-
Configuration menu - View commit details
-
Copy full SHA for 06f789f - Browse repository at this point
Copy the full SHA 06f789fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 77a874b - Browse repository at this point
Copy the full SHA 77a874bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.