-
Notifications
You must be signed in to change notification settings - Fork 406
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
(improvement)(chat) In SchemaCorrector, removing filters from linking…
…Value that do not exist. (#775)
- Loading branch information
Showing
5 changed files
with
230 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
143 changes: 143 additions & 0 deletions
143
chat/core/src/test/java/com/tencent/supersonic/chat/core/corrector/SchemaCorrectorTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| package com.tencent.supersonic.chat.core.corrector; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
|
||
| import com.fasterxml.jackson.core.JsonProcessingException; | ||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import com.tencent.supersonic.chat.api.pojo.SemanticParseInfo; | ||
| import com.tencent.supersonic.chat.api.pojo.SemanticSchema; | ||
| import com.tencent.supersonic.chat.api.pojo.ViewSchema; | ||
| import com.tencent.supersonic.chat.api.pojo.response.SqlInfo; | ||
| import com.tencent.supersonic.chat.core.parser.sql.llm.ParseResult; | ||
| import com.tencent.supersonic.chat.core.pojo.QueryContext; | ||
| import com.tencent.supersonic.chat.core.query.llm.s2sql.LLMReq.ElementValue; | ||
| import com.tencent.supersonic.common.pojo.Constants; | ||
| import com.tencent.supersonic.headless.api.pojo.QueryConfig; | ||
| import com.tencent.supersonic.headless.api.pojo.SchemaElement; | ||
| import java.util.ArrayList; | ||
| import java.util.HashSet; | ||
| import java.util.List; | ||
| import java.util.Set; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class SchemaCorrectorTest { | ||
|
|
||
| private String json = "{\n" | ||
| + " \"viewId\": 1,\n" | ||
| + " \"llmReq\": {\n" | ||
| + " \"queryText\": \"xxx2024年播放量最高的十首歌\",\n" | ||
| + " \"filterCondition\": {\n" | ||
| + " \"tableName\": null\n" | ||
| + " },\n" | ||
| + " \"schema\": {\n" | ||
| + " \"domainName\": \"歌曲\",\n" | ||
| + " \"viewName\": \"歌曲\",\n" | ||
| + " \"fieldNameList\": [\n" | ||
| + " \"商务组\",\n" | ||
| + " \"歌曲名\",\n" | ||
| + " \"播放量\",\n" | ||
| + " \"播放份额\",\n" | ||
| + " \"数据日期\"\n" | ||
| + " ]\n" | ||
| + " },\n" | ||
| + " \"linking\": [\n" | ||
| + "\n" | ||
| + " ],\n" | ||
| + " \"currentDate\": \"2024-02-24\",\n" | ||
| + " \"priorExts\": \"播放份额是小数; \",\n" | ||
| + " \"sqlGenerationMode\": \"2_pass_auto_cot\"\n" | ||
| + " },\n" | ||
| + " \"request\": null,\n" | ||
| + " \"commonAgentTool\": {\n" | ||
| + " \"id\": \"y3LqVSRL\",\n" | ||
| + " \"name\": \"大模型语义解析\",\n" | ||
| + " \"type\": \"NL2SQL_LLM\",\n" | ||
| + " \"viewIds\": [\n" | ||
| + " 1\n" | ||
| + " ]\n" | ||
| + " },\n" | ||
| + " \"linkingValues\": [\n" | ||
| + "\n" | ||
| + " ]\n" | ||
| + "}"; | ||
|
|
||
| @Test | ||
| void doCorrect() throws JsonProcessingException { | ||
| Long viewId = 1L; | ||
| QueryContext queryContext = buildQueryContext(viewId); | ||
| ObjectMapper objectMapper = new ObjectMapper(); | ||
| ParseResult parseResult = objectMapper.readValue(json, ParseResult.class); | ||
|
|
||
|
|
||
| String sql = "select 歌曲名 from 歌曲 where 发行日期 >= '2024-01-01' " | ||
| + "and 商务组 = 'xxx' order by 播放量 desc limit 10"; | ||
| SemanticParseInfo semanticParseInfo = new SemanticParseInfo(); | ||
| SqlInfo sqlInfo = new SqlInfo(); | ||
| sqlInfo.setS2SQL(sql); | ||
| sqlInfo.setCorrectS2SQL(sql); | ||
| semanticParseInfo.setSqlInfo(sqlInfo); | ||
|
|
||
| SchemaElement schemaElement = new SchemaElement(); | ||
| schemaElement.setView(viewId); | ||
| semanticParseInfo.setView(schemaElement); | ||
|
|
||
|
|
||
| semanticParseInfo.getProperties().put(Constants.CONTEXT, parseResult); | ||
|
|
||
| SchemaCorrector schemaCorrector = new SchemaCorrector(); | ||
| schemaCorrector.removeFilterIfNotInLinkingValue(queryContext, semanticParseInfo); | ||
|
|
||
| assertEquals("SELECT 歌曲名 FROM 歌曲 WHERE 发行日期 >= '2024-01-01' " | ||
| + "ORDER BY 播放量 DESC LIMIT 10", semanticParseInfo.getSqlInfo().getCorrectS2SQL()); | ||
|
|
||
| parseResult = objectMapper.readValue(json, ParseResult.class); | ||
|
|
||
| List<ElementValue> linkingValues = new ArrayList<>(); | ||
| ElementValue elementValue = new ElementValue(); | ||
| elementValue.setFieldName("商务组"); | ||
| elementValue.setFieldValue("xxx"); | ||
| linkingValues.add(elementValue); | ||
| parseResult.setLinkingValues(linkingValues); | ||
| semanticParseInfo.getProperties().put(Constants.CONTEXT, parseResult); | ||
|
|
||
| semanticParseInfo.getSqlInfo().setCorrectS2SQL(sql); | ||
| semanticParseInfo.getSqlInfo().setS2SQL(sql); | ||
| schemaCorrector.removeFilterIfNotInLinkingValue(queryContext, semanticParseInfo); | ||
| assertEquals("SELECT 歌曲名 FROM 歌曲 WHERE 发行日期 >= '2024-01-01' " | ||
| + "AND 商务组 = 'xxx' ORDER BY 播放量 DESC LIMIT 10", semanticParseInfo.getSqlInfo().getCorrectS2SQL()); | ||
|
|
||
| } | ||
|
|
||
| private QueryContext buildQueryContext(Long viewId) { | ||
| QueryContext queryContext = new QueryContext(); | ||
| List<ViewSchema> viewSchemaList = new ArrayList<>(); | ||
| ViewSchema viewSchema = new ViewSchema(); | ||
| QueryConfig queryConfig = new QueryConfig(); | ||
| viewSchema.setQueryConfig(queryConfig); | ||
| SchemaElement schemaElement = new SchemaElement(); | ||
| schemaElement.setView(viewId); | ||
| viewSchema.setView(schemaElement); | ||
| Set<SchemaElement> dimensions = new HashSet<>(); | ||
| SchemaElement element1 = new SchemaElement(); | ||
| element1.setView(1L); | ||
| element1.setName("歌曲名"); | ||
| dimensions.add(element1); | ||
|
|
||
| SchemaElement element2 = new SchemaElement(); | ||
| element2.setView(1L); | ||
| element2.setName("商务组"); | ||
| dimensions.add(element2); | ||
|
|
||
| SchemaElement element3 = new SchemaElement(); | ||
| element3.setView(1L); | ||
| element3.setName("发行日期"); | ||
| dimensions.add(element3); | ||
|
|
||
| viewSchema.setDimensions(dimensions); | ||
| viewSchemaList.add(viewSchema); | ||
|
|
||
| SemanticSchema semanticSchema = new SemanticSchema(viewSchemaList); | ||
| queryContext.setSemanticSchema(semanticSchema); | ||
| return queryContext; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters