Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Implement pose estimation Posenet #157

Merged
merged 3 commits into from Oct 20, 2023
Merged

Feature - Implement pose estimation Posenet #157

merged 3 commits into from Oct 20, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 12, 2023

No description provided.

@PaulTR
Copy link
Collaborator

PaulTR commented Oct 16, 2023

Looks like some of the points may be incorrectly connected, and scaling might be off?

Screenshot_20231016-094456

@PaulTR
Copy link
Collaborator

PaulTR commented Oct 16, 2023

In case it helps, there was another PR not too long ago that the author closed due to it taking a moment to get to PR reviews that might be useful https://github.com/tensorflow/flutter-tflite/tree/pose_detection_olololoe

@ghost
Copy link
Author

ghost commented Oct 17, 2023

Looks like some of the points may be incorrectly connected, and scaling might be off?

Screenshot_20231016-094456

I apologize for the mistake. I used the wrong aspect ratio when refactoring the code. I have updated the code and it now works correctly on Android, but it is still slightly incorrect on iOS. I am working on fixing it, but it may take some time. Thank you for your patience.

@PaulTR
Copy link
Collaborator

PaulTR commented Oct 17, 2023

Cool sounds good. Thanks!

@ghost
Copy link
Author

ghost commented Oct 18, 2023

Hi Mr @PaulTR , I fixed the scale issue on Android and iOS. Can you please take a look? Thanks!

@PaulTR
Copy link
Collaborator

PaulTR commented Oct 20, 2023

Alright looks good on iPhone, iPad, and an Android phone. Thanks Duy!

@PaulTR PaulTR merged commit e1fa0ce into tensorflow:main Oct 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants