Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rules_python in Bazel builds #821

Open
mhucka opened this issue Dec 4, 2024 · 0 comments
Open

Use rules_python in Bazel builds #821

mhucka opened this issue Dec 4, 2024 · 0 comments
Labels
area/code-health Concerns stability, quality, technical debt, etc. area/dependencies Concerns libraries or other software that TFQ depends on area/installation Concerns installation of TFQ priority/p2 Next release should contain it

Comments

@mhucka
Copy link
Member

mhucka commented Dec 4, 2024

The consensus is that the right way to build Python software with Bazel is to use bazelbuild/rules_python. Bazel doesn't see changes in the Python environment installed by pip or elsewhere; it's only aware of things that are "imported" into it.

Doing this will take some work in figuring out how to avoid replicating the contents of requirements.txt in the Bazel files, so that we maintain one source of truth for the Python dependencies.

@mhucka mhucka added area/dependencies Concerns libraries or other software that TFQ depends on area/code-health Concerns stability, quality, technical debt, etc. priority/p2 Next release should contain it area/installation Concerns installation of TFQ labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code-health Concerns stability, quality, technical debt, etc. area/dependencies Concerns libraries or other software that TFQ depends on area/installation Concerns installation of TFQ priority/p2 Next release should contain it
Projects
Development

No branches or pull requests

1 participant