Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Internal Backend Hooks and Behavior Extensions #152

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rlizzo
Copy link
Member

@rlizzo rlizzo commented Oct 27, 2019

inital work on opening up entrypoints and areas for dynamic loading of backends and behavior

This will be a larger project and very much a work in progress for the forseeable future.

Motivation and Context

Why is this change required? What problem does it solve?:

TODO

Description

Describe your changes in detail:

TODO

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Documentation update
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Is this PR ready for review, or a work in progress?

  • Ready for review
  • Work in progress

How Has This Been Tested?

Put an x in the boxes that apply:

  • Current tests cover modifications made
  • New tests have been added to the test suite
  • Modifications were made to existing tests to support these changes
  • Tests may be needed, but they are not included when the PR was proposed
  • I don't know. Help!

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have signed (or will sign when prompted) the tensorwork CLA.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@rlizzo rlizzo added the WIP Don't merge; Work in Progress label Oct 27, 2019
@rlizzo rlizzo added this to the v0.5.0 milestone Oct 27, 2019
@rlizzo rlizzo self-assigned this Oct 27, 2019
@codecov
Copy link

codecov bot commented Oct 27, 2019

Codecov Report

Merging #152 into master will decrease coverage by 44.51%.
The diff coverage is 49.36%.

@@             Coverage Diff             @@
##           master     #152       +/-   ##
===========================================
- Coverage   95.28%   50.77%   -44.51%     
===========================================
  Files          66       67        +1     
  Lines       11878    12009      +131     
  Branches     1029     1039       +10     
===========================================
- Hits        11317     6097     -5220     
- Misses        374     5899     +5525     
+ Partials      187       13      -174     
Impacted Files Coverage Δ
src/hangar/backends/__init__.py 0.00% <ø> (-100.00%) ⬇️
src/hangar/backends/hdf5_00.py 0.00% <0.00%> (-92.99%) ⬇️
src/hangar/backends/hdf5_01.py 0.00% <0.00%> (-90.16%) ⬇️
src/hangar/backends/numpy_10.py 0.00% <0.00%> (-92.91%) ⬇️
src/hangar/backends/remote_50.py 0.00% <0.00%> (-93.48%) ⬇️
src/hangar/backends/selection.py 0.00% <0.00%> (-90.48%) ⬇️
src/hangar/cli/cli.py 0.00% <0.00%> (-89.52%) ⬇️
src/hangar/cli/utils.py 0.00% <0.00%> (-41.67%) ⬇️
tests/test_cli_utils.py 91.67% <91.67%> (ø)
src/hangar/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
... and 43 more

@lgtm-com
Copy link

lgtm-com bot commented Nov 26, 2019

This pull request introduces 1 alert when merging 884db5a into be7d40e - view on LGTM.com

new alerts:

  • 1 for Unused import

@CLAassistant
Copy link

CLAassistant commented Apr 10, 2020

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Don't merge; Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants