feat(deno): make checks on CI

teomrd · Nov 1, 2024 · 2cd8132 · 2cd8132
1 parent 5ff419d
commit 2cd8132
Show file tree

Hide file tree

Showing 6 changed files with 20 additions and 21 deletions.
diff --git a/.github/workflows/audit.yml b/.github/workflows/audit.yml
diff --git a/.github/workflows/on-pull-request.yml b/.github/workflows/on-pull-request.yml
@@ -0,0 +1,17 @@
+name: On Pull Requests
+on:
+  push:
+    branches:
+      - deno
+  pull_request:
+    branches:
+      - main
+jobs:
+  lighthouseci:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: denoland/setup-deno@v2
+        with:
+          deno-version: v2.x
+      - run: make checks
diff --git a/deno.json b/deno.json
@@ -12,7 +12,6 @@
   "imports": {
     "@std/assert": "jsr:@std/assert@1",
     "@types/textarea-caret": "npm:@types/textarea-caret@^3.0.3",
-    "@types/showdown": "npm:@types/showdown@^2.0.6",
     "@lhci/cli": "npm:@lhci/cli@0.14.0",
     "esbuild": "npm:esbuild@^0.24.0",
     "workbox": "npm:workbox@^0.0.0",

diff --git a/deno.lock b/deno.lock
diff --git a/package.json b/package.json
@@ -6,6 +6,7 @@
   "author": "teomrd <mironidis.gr@gmail.com>",
   "license": "GPL-3.0-only",
   "dependencies": {
+    "@types/showdown": "^2.0.6",
     "github-markdown-css": "^5.7.0",
     "multiformats": "^13.3.1",
     "nanoid": "^5.0.8",

diff --git a/src/js/components/organisms/markdown/mdToHtml.ts b/src/js/components/organisms/markdown/mdToHtml.ts
@@ -12,4 +12,4 @@ const converter = new showdown.Converter({
 
 converter.setFlavor("github");
 
-export const convertMarkDownToHtml = (md) => converter.makeHtml(md);
+export const convertMarkDownToHtml = (md: string) => converter.makeHtml(md);
Original file line number	Diff line number	Diff line change
Expand Up		@@ -12,4 +12,4 @@ const converter = new showdown.Converter({

		converter.setFlavor("github");

		export const convertMarkDownToHtml = (md) => converter.makeHtml(md);
		export const convertMarkDownToHtml = (md: string) => converter.makeHtml(md);