Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use QuadratureIterator in examples #56

Merged
merged 11 commits into from
Jan 17, 2024
Merged

Use QuadratureIterator in examples #56

merged 11 commits into from
Jan 17, 2024

Conversation

AbdAlazezAhmed
Copy link
Collaborator

Uses QuadratureIterator in examples, changes some qpᵢ to qp, uses qp.i for indexing, and dispatches spatial_coordinate.

@termi-official
Copy link
Owner

Nice catch!

Can you add some very rudimentary test for the fsi and microstructure calls?

termi-official
termi-official approved these changes Jan 17, 2024
View reviewed changes
Copy link
Owner

@termi-official termi-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM. Everything now works as expected. I changed the test quadrature to order 2 and increased the mesh size, so the field is fine enough to be tested properly.

test/test_microstructures.jl Outdated Show resolved Hide resolved
test/test_microstructures.jl Outdated Show resolved Hide resolved
test/test_microstructures.jl Outdated Show resolved Hide resolved
test/test_microstructures.jl Show resolved Hide resolved
@termi-official termi-official merged commit ee55ce0 into termi-official:main Jan 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@termi-official termi-official termi-official approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbdAlazezAhmed @termi-official