Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geselowitz ECG #85

Merged
merged 39 commits into from
Aug 28, 2024
Merged

Conversation

AbdAlazezAhmed
Copy link
Collaborator

For #71 and #72

This was linked to issues Feb 11, 2024
Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
Project.toml Outdated Show resolved Hide resolved
src/solver/ecg.jl Outdated Show resolved Hide resolved
src/solver/ecg.jl Outdated Show resolved Hide resolved
src/solver/ecg.jl Outdated Show resolved Hide resolved
src/solver/ecg.jl Outdated Show resolved Hide resolved
@AbdAlazezAhmed AbdAlazezAhmed changed the title [Almost there wip] Geselowitz ECG + Poisson reconstruction Geselowitz ECG + Poisson reconstruction Mar 6, 2024
@AbdAlazezAhmed AbdAlazezAhmed marked this pull request as ready for review March 6, 2024 18:41
Copy link
Owner

@termi-official termi-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume further progress is blocked until we have subdomains or intergrid transfer operators merged?

test/integration/test_ecg.jl Outdated Show resolved Hide resolved
docs/src/assets/references.bib Outdated Show resolved Hide resolved
examples/leads.jl Outdated Show resolved Hide resolved
src/modeling/core/coefficients.jl Outdated Show resolved Hide resolved
src/modeling/core/coefficients.jl Outdated Show resolved Hide resolved
src/solver/ecg.jl Outdated Show resolved Hide resolved
src/solver/ecg.jl Outdated Show resolved Hide resolved
src/solver/ecg.jl Outdated Show resolved Hide resolved
src/solver/ecg.jl Outdated Show resolved Hide resolved
src/solver/ecg.jl Outdated Show resolved Hide resolved
@termi-official
Copy link
Owner

You should be able to revert the hotfixes in src/solver and src/modeling and merge master.

There is now also a nodal transfer operator (not tested) which can be used to transfer the solution between heart and torso.

@termi-official termi-official changed the title Geselowitz ECG + Poisson reconstruction Geselowitz ECG Jul 12, 2024
@AbdAlazezAhmed AbdAlazezAhmed marked this pull request as draft August 16, 2024 22:11
@AbdAlazezAhmed AbdAlazezAhmed marked this pull request as ready for review August 19, 2024 17:40
Copy link
Owner

@termi-official termi-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

src/processing/ecg.jl Outdated Show resolved Hide resolved
src/processing/ecg.jl Outdated Show resolved Hide resolved
test/integration/test_ecg.jl Outdated Show resolved Hide resolved
AbdAlazezAhmed and others added 2 commits August 27, 2024 22:14
Co-authored-by: Dennis Ogiermann <termi-official@users.noreply.github.com>
@termi-official termi-official merged commit 5183bd8 into termi-official:main Aug 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poisson ECG reconstruction Geselowitz' lead field ECG
2 participants