Added more options for the CameraPhoto #694
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a few new features: Fixed the sensor max resolution, before it was limited to 12MP, at least on my Xiaomi Mi Note 10. Added support for setting the iso/exposure time, EV compensation, flash control (the auto mode doesn't work on my phone though), and focus distance.
Added support for setting the preview time
|
Would love to see this integrated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added more command line options for the CameraPhoto unit. I didn't change the shell script that calls it, because I am not good at sh scripting. But it can be used directly, as such: /data/data/com.termux/files/usr/libexec/termux-api CameraPhoto --es camera 0 --es preview_time 400 --es flash auto --es no_processing on --es focus 620 --es file /data/data/com.termux/files/home/storage/dcim/Camera/testiso5.jpg
I've only tested it on my Xiaomi Mi Note 10 main camera, but from my experience with other Android Camera2 API somethings might or might not work on other phones. Many of them do not respect the standard, report wrong capabilities, and so on. So I would appreciate if people could verify it on their phone. I've left a few debug things on, such as printing some of the parameters, but I can remove that if desired. This is the first time I am contributing to someone's else project, so please be kind to me if I made any mistakes :)