Do not show AutoFill UI on Termux start and add support for usernames #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agnostic-apollo
force-pushed
the
autofill-improv
branch
from
962f581 to
f6e2300
Compare
…for usernames - The AutoFill type and hints are no longer hardcoded in `TerminalView` class and `TermuxActivity` layout xml. They are dynamically set to required values before making a manual AutoFill request and reverted back afterwards to default values. The hardcoded value `AUTOFILL_TYPE_TEXT` returned by `getAutofillType()` was causing the AutoFill UI to show on Activity starts, this will return `AUTOFILL_TYPE_NONE` by default now so that AutoFill UI isn't shown automatically. - The AutoFill importance is no longer hardcoded in `TermuxActivity` layout xml and is returned by `TerminalView` class itself by `getImportantForAutofill()`. - The AutoFill function in `TermuxActivity` for making a manual AutoFill request is moved to `TerminalView` class. This and moving of hardcoded values to `TerminalView` class mentioned above is done as complete logic of AutoFill should be handled by `TerminalView` class itself and not scattered in various places. - The Terminal context menu now supports AutoFilling a username. Note that GBoard/Google Password Manager seems to have a bug where it will still show `Pick a saved password` instead of username, even though `AUTOFILL_HINT_USERNAME` is being requested, however it will still AutoFill a username of selected entry correctly. - Pressing the back button to close the keyboard will also cancel the current manually requested AutoFill request and UI will not show when keyboard is opened again. Closes #3909
agnostic-apollo
force-pushed
the
autofill-improv
branch
from
f6e2300 to
c2d57f2
Compare
fornwall
added a commit
to termux-play-store/termux-apps
that referenced
this pull request
Oct 1, 2024
fornwall
added a commit
to termux-play-store/termux-apps
that referenced
this pull request
Oct 21, 2024
fornwall
added a commit
to termux-play-store/termux-apps
that referenced
this pull request
Oct 21, 2024
…for usernames Merge termux/termux-app#4125 and termux/termux-app#4165 Co-authored-by: @AChep <mail@artemchep.com> Co-authored-by: @agnostic-apollo <agnosticapollo@gmail.com>
fornwall
added a commit
to termux-play-store/termux-apps
that referenced
this pull request
Oct 21, 2024
…for usernames Merge termux/termux-app#4125 and termux/termux-app#4165 Co-authored-by: @AChep <mail@artemchep.com> Co-authored-by: @agnostic-apollo <agnosticapollo@gmail.com>
fornwall
added a commit
to termux-play-store/termux-apps
that referenced
this pull request
Oct 21, 2024
…for usernames Merge termux/termux-app#4125 and termux/termux-app#4165 Co-authored-by: @AChep <mail@artemchep.com> Co-authored-by: @agnostic-apollo <agnosticapollo@gmail.com>
|
Thank you for fixing this. I'd love to patch my Termux with this PR . I notice that the latest prerelease is from June 2024 which predates this change so I tried to build Termux from source yesterday and ended up riding the Android Studio struggle bus for a couple of hours. Is there any chance that a new {pre,}release will ship with this change in the coming months? |
|
A new beta will be released in coming weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TerminalViewclass andTermuxActivitylayout xml. They are dynamically set to required values before making a manual AutoFill request and reverted back afterwards to default values. The hardcoded valueAUTOFILL_TYPE_TEXTreturned bygetAutofillType()was causing the AutoFill UI to show on Activity starts, this will returnAUTOFILL_TYPE_NONEby default now so that AutoFill UI isn't shown automatically.TermuxActivitylayout xml and is returned byTerminalViewclass itself bygetImportantForAutofill().TermuxActivityfor making a manual AutoFill request is moved toTerminalViewclass. This and moving of hardcoded values toTerminalViewclass mentioned above is done as complete logic of AutoFill should be handled byTerminalViewclass itself and not scattered in various places.Pick a saved passwordinstead of username, even thoughAUTOFILL_HINT_USERNAMEis being requested, however it will still AutoFill a username of selected entry correctly.Closes #3909
GitHub action builds are available at https://github.com/termux/termux-app/actions/runs/10581452105?pr=4125.