feat: Variable repository_lambda_read_access added #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoshel
changed the title
akoshel
changed the title
akoshel
changed the title
|
it is correct as written - this is intended to support cross account permissions as well |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ECR lambda access policy for private repositories.
Motivation and Context
The current implementation of repository_lambda_read_access_arns necessitates a list of Lambda service role ARNs, but this requirement is not essential.
https://github.com/terraform-aws-modules/terraform-aws-ecr/blob/master/main.tf#L67C52-L67C102
https://docs.aws.amazon.com/lambda/latest/dg/images-create.html
Changes
Added new variable bool repository_lambda_read_access to set lambda access ecr policy
repository_lambda_read_access_arns will work as before, description updated as deprecated variable