fix: use different sid for ecr and ecr-public resources

[Baachi]

Description

Without this change, this produces an invalid Iam policy, since there is a duplicated sid.

Motivation and Context

As mentioned above, this MR now produces a valid IAM policy.

Breaking Changes

No

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects
• I have executed pre-commit run -a on my pull request

[bryantbiggs]

please start with an issue and a reproduction - I'm not sure why you would have a conflict since the policy is per module definition and a module definition is either a private or public repository - not both

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.