feat: Allow to specify custom KMS key for S3 object #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The aws_s3_object resource currently does not allow to specify to kms_key_id parameter to provide a custom KMS key ARN to use for encryption. A new variable "s3_kms_key_id" has been introduced to allow to specify it.
New example 's3-custom-kms-key' was added and mentioned in the main README
antonbabenko
approved these changes
Nov 3, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Nov 3, 2023
## [6.3.0](v6.2.0...v6.3.0) (2023-11-03) ### Features * Allow to specify custom KMS key for S3 object ([#505](#505)) ([eb339d6](eb339d6))
|
This PR is included in version 6.3.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a new variable
s3_kms_key_idthat allows to specify the KMS key that is used to encrypt the S3 object representing the Lambda package.Motivation and Context
We are using S3 buckets with custom KMS key encryption to store our Lambda build artifacts. This module currently does not allow to specify a KMS key on the
aws_s3_objectresource which leads to failures when trying to upload the package (denied by bucket policy).Breaking Changes
No
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)Added example
s3-custom-kms-keyexamples/*projectsChanges were validated by deploying the
completeexamplepre-commit run -aon my pull request