-
-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add control to use timestamp to trigger the package creation or not (useful for CI/CD) #521
feat: Add control to use timestamp to trigger the package creation or not (useful for CI/CD) #521
Conversation
This PR has been automatically marked as stale because it has been open 30 days |
@antonbabenko Would you have some time to take a look at this PR please? 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work with this PR and test.sh
in particular - it helped a lot!
## [6.7.0](v6.6.0...v6.7.0) (2024-01-14) ### Features * Add control to use timestamp to trigger the package creation or not (useful for CI/CD) ([#521](#521)) ([57dbfc1](57dbfc1))
This PR is included in version 6.7.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add a variable
trigger_on_package_timestamp
(boolean - defaults totrue
) to whether use timestamp to trigger the package creation or not.Motivation and Context
Problem
terraform apply
. The lambda is created.builds
directory (to simulate a CICD job with an empty environment).terraform plan
again, it will detect a drift because the timestamp has changed.One solution was to add the variable
recreate_missing_package = false
, but when the CICD job (without anybuilds
directory) runsterraform apply
will face this error:Solution
Add a variable
trigger_on_package_timestamp
(boolean - defaults totrue
) to whether use timestamp to trigger the package creation or not.Fix #396
Breaking Changes
None.
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull requestI have added an
example/simple-cicd
with atest.sh
inside to run the test scenario.