feat: Complex variable types for module zones #111
Conversation
kevcube
changed the title
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Not stale |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This is really nice! Any chance of getting your input here @antonbabenko ? |
Yes, I plan to get back to this and many other PRs in terraform-aws-modules after AWS reinvent. |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
How was re:invent @antonbabenko ? 😅 |
There was a problem hiding this comment.
These changes certainly look like an improvement, but it is essential to keep backward compatibility in mind and don't introduce breaking changes.
Please make sure that the code in examples/complete works as expected (now I see the error: each.value.vpc is null Cannot use a null value in for_each.).
@BeyondEvil Thanks for asking, it went well - https://www.youtube.com/watch?v=fX7c2GGqTWs 😅 |
antonbabenko
changed the title
Oh nice! I'll have a look. 👍 |
use descriptive variable types.
versions.tfalready specifies higher than 1.3.0 so no change needed there.