feat: Automatically append .fifo to fifo topic names #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, we automatically append the .fifo suffix to fifo topic names since it is required by AWS SNS. We also sanitize the name input to ensure that if users have already included the .fifo suffix in their topic names it will not be appended again.
antonbabenko
pushed a commit
that referenced
this pull request
Jul 5, 2024
## [6.1.0](v6.0.1...v6.1.0) (2024-07-05) ### Features * Automatically append .fifo to fifo topic names ([#55](#55)) ([cfd23c1](cfd23c1))
|
This PR is included in version 6.1.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change, we automatically append the .fifo suffix to fifo topic names since it is required by AWS SNS. We also sanitise the name input to ensure that if users have already included the .fifo suffix in their topic names it will not be appended again.
Motivation and Context
Error: invalid topic namewhen creating a FIFO Topic #54Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request