Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GKE): add reservation samples #665

Merged
merged 5 commits into from
May 19, 2024
Merged

feat(GKE): add reservation samples #665

merged 5 commits into from
May 19, 2024

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented May 13, 2024

Description

add GKE reservation samples

Checklist

Readiness

  • Yes, merge this PR after it is approved
  • No, don't merge this PR after it is approved

Style

Testing

Intended location

API enablement

  • If the sample needs an API enabled to pass testing, I have added the service to the Test setup file

Review

  • If this sample adds a new directory, I have added codeowners to the CODEOWNERS file

@apeabody apeabody force-pushed the ap/gke-ap-reservation branch 9 times, most recently from 7340193 to d7f9e8e Compare May 14, 2024 23:26
@apeabody apeabody changed the title feat(GKE): add AP reservation sample feat(GKE): add reservation samples May 14, 2024
@apeabody apeabody marked this pull request as ready for review May 15, 2024 05:39
@apeabody apeabody requested review from a team as code owners May 15, 2024 05:39
Copy link

snippet-bot bot commented May 15, 2024

Here is the summary of changes.

You are about to add 9 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

gke/autopilot/reservation/main.tf Show resolved Hide resolved
gke/standard/zonal/reservation/main.tf Outdated Show resolved Hide resolved
gke/standard/zonal/reservation/main.tf Outdated Show resolved Hide resolved
@glasnt glasnt enabled auto-merge (squash) May 16, 2024 00:28
@glasnt
Copy link
Contributor

glasnt commented May 16, 2024

Unrelated CI failure. Will try re-running.

@glasnt
Copy link
Contributor

glasnt commented May 16, 2024

/gcbrun

@apeabody
Copy link
Contributor Author

(re-triggered from another flake)

@apeabody apeabody marked this pull request as draft May 17, 2024 19:05
auto-merge was automatically disabled May 17, 2024 19:05

Pull request was converted to draft

@apeabody
Copy link
Contributor Author

The repeated CI failure is from an unrelated GKE sample. Moved my experiment on finer test filtering to #669

@apeabody apeabody marked this pull request as ready for review May 19, 2024 15:33
@apeabody apeabody merged commit 3cb5373 into main May 19, 2024
10 checks passed
@apeabody apeabody deleted the ap/gke-ap-reservation branch May 19, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants