-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GKE): add reservation samples #665
Conversation
7340193
to
d7f9e8e
Compare
Here is the summary of changes. You are about to add 9 region tags.
This comment is generated by snippet-bot.
|
7efbe5f
to
c32b21f
Compare
c32b21f
to
b806be9
Compare
Unrelated CI failure. Will try re-running. |
/gcbrun |
(re-triggered from another flake) |
Pull request was converted to draft
31ca3e5
to
7eb8138
Compare
The repeated CI failure is from an unrelated GKE sample. Moved my experiment on finer test filtering to #669 |
Description
add GKE reservation samples
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s): https://cloud.google.com/kubernetes-engine/docs/how-to/consuming-reservations
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review