-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI): directory specific test change pruning #669
Open
apeabody
wants to merge
27
commits into
main
Choose a base branch
from
ap/dir-specific-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeabody
force-pushed
the
ap/dir-specific-tests
branch
from
May 17, 2024 20:48
e8bed06
to
f774dd5
Compare
11 tasks
@apeabody did you plan on iterating on this one more? it's been unchanged in drafts for a while |
apeabody
force-pushed
the
ap/dir-specific-tests
branch
from
October 14, 2024 18:28
ccc1a32
to
02d581f
Compare
apeabody
force-pushed
the
ap/dir-specific-tests
branch
from
October 14, 2024 18:38
02d581f
to
ab977b0
Compare
glasnt
reviewed
Oct 14, 2024
Looks like the infra change escape is now working, but we can't easily test the rest of the logic until this code is merged (without shenanigans) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(includes a de minimis sample change to force a test)
Checklist
Readiness
Style
guide
Testing
I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
Yes, this sample will be (or already is) included on cloud.google.com
Location(s):
No, this sample won't be included on cloud.google.com
Reason:
API enablement
Review