Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: Set endpoint-independent-mapping default to false #113

Closed
wants to merge 5 commits into from
Closed

fix!: Set endpoint-independent-mapping default to false #113

wants to merge 5 commits into from

Conversation

sclausson
Copy link

Fix for issue #112

@sclausson sclausson requested a review from a team as a code owner April 26, 2023 08:37
@sclausson sclausson mentioned this pull request May 11, 2023
Merged
@apeabody
Copy link
Contributor

/gcbrun

@imrannayer
Copy link
Collaborator

@sclausson @apeabody this will be breaking change. Since we already have 4.0 lined up this can go in there.

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer
Copy link
Collaborator

imrannayer commented Jun 13, 2023 •
edited
Loading

@sclausson Integration test is failing for enableEndpointIndependentMapping value. Can you plz change this to false in:

  1. https://github.com/terraform-google-modules/terraform-google-cloud-nat/blob/master/test/integration/advanced/testdata/TestAdvanced.json
  2. https://github.com/terraform-google-modules/terraform-google-cloud-nat/blob/master/test/integration/basic/testdata/TestBasic.json
  3. https://github.com/terraform-google-modules/terraform-google-cloud-nat/blob/master/test/integration/subnetworks/testdata/TestSubnetworks.json

@apeabody apeabody changed the title fix: Set endpoint-independent-mapping default to false fix!: Set endpoint-independent-mapping default to false Jun 13, 2023
@imrannayer
Copy link
Collaborator

@sclausson r u still working on this PR?

@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Aug 26, 2023
@imrannayer imrannayer removed the Stale label Aug 27, 2023
@github-actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 26, 2023
@imrannayer imrannayer removed the Stale label Oct 26, 2023
@apeabody apeabody mentioned this pull request Oct 30, 2023
Merged
@apeabody
Copy link
Contributor

Thanks @sclausson - Included with test fixture updates in #129

@apeabody apeabody closed this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sclausson @apeabody @imrannayer