Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(enable_endpoint_independent_mapping=false)!: upgraded versions.tf to include minor bumps from tpg v5 #129

Merged
merged 17 commits into from
Oct 30, 2023

Conversation

g-awmalik
Copy link
Contributor

@g-awmalik g-awmalik commented Oct 6, 2023

Fixes: #112, #113

For details see upgrading_to_v5.0.md

@g-awmalik g-awmalik requested review from imrannayer and a team as code owners October 6, 2023 23:15
@imrannayer
Copy link
Collaborator

@g-awmalik there is a behavior change in 5.x. Default value of enable_endpoint_independent_mapping is now set to FALSE. It was TRUE pre 5.X.
Should we make it a breaking change?

@imrannayer
Copy link
Collaborator

@g-awmalik for some reason gcloud command is returning an extra information autoNetworkTier. We may need to add it in test data

@apeabody
Copy link
Contributor

apeabody commented Oct 30, 2023

@g-awmalik there is a behavior change in 5.x. Default value of enable_endpoint_independent_mapping is now set to FALSE. It was TRUE pre 5.X. Should we make it a breaking change?

Alternatively we could switch the variable from null to true which maintain the previous behavior and so avoid a breaking change on requiring tpg v5, however that would differ from the provider new default: https://registry.terraform.io/providers/hashicorp/google/5.0.0/docs/guides/version_5_upgrade#enable_endpoint_independent_mapping-now-defaults-to-apis-default-value-which-is-false

@apeabody
Copy link
Contributor

@g-awmalik for some reason gcloud command is returning an extra information autoNetworkTier. We may need to add it in test data

fixed and committed to repo

@apeabody
Copy link
Contributor

@g-awmalik there is a behavior change in 5.x. Default value of enable_endpoint_independent_mapping is now set to FALSE. It was TRUE pre 5.X. Should we make it a breaking change?

Alternatively we could switch the variable from null to true which maintain the previous behavior and so avoid a breaking change on requiring tpg v5, however that would differ from the provider new default: https://registry.terraform.io/providers/hashicorp/google/5.0.0/docs/guides/version_5_upgrade#enable_endpoint_independent_mapping-now-defaults-to-apis-default-value-which-is-false

Looks like the preferable option is, in-line with tpg v5 default, is false. So we'll make this a breaking change.

@apeabody apeabody changed the title chore: upgraded versions.tf to include minor bumps from tpg v5 fix(tpg5)!: upgraded versions.tf to include minor bumps from tpg v5 Oct 30, 2023
@apeabody apeabody changed the title fix(tpg5)!: upgraded versions.tf to include minor bumps from tpg v5 fix!: upgraded versions.tf to include minor bumps from tpg v5 Oct 30, 2023
@apeabody apeabody changed the title fix!: upgraded versions.tf to include minor bumps from tpg v5 fix(enable_endpoint_independent_mapping=false)!: upgraded versions.tf to include minor bumps from tpg v5 Oct 30, 2023
@apeabody apeabody merged commit 30bcb56 into master Oct 30, 2023
4 checks passed
@apeabody apeabody deleted the chore/tpg-bump branch October 30, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoint-Independent Mapping default value should be false (not null)
3 participants