Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TPG >= 4.53)!: update regional proxy lb module #111

Conversation

MahekKatariya
Copy link
Contributor

@MahekKatariya MahekKatariya commented Sep 19, 2024

Pull Request Updates

This PR introduces several improvements to enhance flexibility and user experience when creating resources in Google Cloud using Terraform. The following changes have been made:

  1. Default Value for target_tags:

    • A default value of [] has been added to the target_tags variable. This allows users to omit this value if they do not wish to create firewall rules, simplifying the configuration.
  2. Default Value for proxy_only_subnet_cidr:

    • A default value of "" has been added to the proxy_only_subnet_cidr variable. Users can now omit this value if they do not wish to create a proxy-only subnet, providing more flexibility in subnet configuration.
  3. New proxy_header Parameter for google_compute_region_target_tcp_proxy:

    • A new optional parameter, proxy_header, has been introduced in the google_compute_region_target_tcp_proxy resource. Users can now specify a value for proxy_header if desired. The default value is set to NONE.

These changes make it easier for users to create custom configurations without unnecessary overhead, while also providing sensible defaults.

@imrannayer
Copy link
Collaborator

@MahekKatariya thanks for the PR. Can you plz update version.tf of regional proxy load balancer. Change minimum provider required to 4.53 as this feature was part of 4.53 release

@imrannayer imrannayer self-assigned this Sep 19, 2024
@MahekKatariya
Copy link
Contributor Author

@MahekKatariya thanks for the PR. Can you plz update version.tf of regional proxy load balancer. Change minimum provider required to 4.53 as this feature was part of 4.53 release

@imrannayer Changed minimum version to 4.53

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer changed the title FIX: update regional proxy lb module fix: update regional proxy lb module Sep 23, 2024
@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer changed the title fix: update regional proxy lb module fix(TPG >= 4.53)!: update regional proxy lb module Sep 23, 2024
@imrannayer imrannayer self-requested a review September 23, 2024 16:05
@imrannayer imrannayer merged commit b1ecad2 into terraform-google-modules:master Sep 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants