feat: Enable multiple display name #99
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
dkuji
changed the title
dkuji
force-pushed
the
enable-multiple-display-name
branch
from
da89d2d
to
4a8ae8b
Compare
dkuji
force-pushed
the
enable-multiple-display-name
branch
from
4a8ae8b
to
3a298fc
Compare
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
There was a problem hiding this comment.
Thanks for the PR @dkuji! A minor comment but LGTM otherwise
|
@bharathkkb PTAL? I fixed that. |
|
/gcbrun |
There was a problem hiding this comment.
Thanks for the contribution @dkuji!
Relevant output from the list test:
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=autogen' '--exclude=*.tfvars' '--exclude=*metadata.yaml' /workspace/README.md /tmp/tmp.kEurYfZhXH/generate_docs/workspace/README.md
64d63
< | display\_names | display names variable. |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
Resolves #86
Allows any display name to be used for each account when creating multiple accounts.