Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for external projects #327

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

elliottslaughter
Copy link
Member

@elliottslaughter elliottslaughter commented Dec 11, 2018

Current status:

  • Regent
  • Rigel

Deferred:

  • Opt

Others?

@aiverson
Copy link
Contributor

I am currently working on updating quicksand for the current version of Terra. When I have it running, should that become part of this test package, and what should I do with regards to that?

@elliottslaughter
Copy link
Member Author

Yes, if you have significant pieces of Terra code (ideally with tests), let's include them as external tests on the CI. The goal of this effort is to have as broad test coverage as possible, so that we can have some degree of assurance that we aren't breaking the ecosystem when we make changes.

Depending on whether you get to it before or after this PR merges, we could either add it here or as a new PR.

@aiverson
Copy link
Contributor

I don't anticipate getting it here before this PR merges. Quicksand has a considerable amount of nontrivial code in it, and large parts need major rewrites to fit the changes to the language since it was last maintained.

@elliottslaughter
Copy link
Member Author

@Mx7f @ProfFan Is there a way to build Opt without CUDA support? Otherwise I'm not sure I have any realistic hope of testing it in CI. (I can install CUDA, but there will never be a GPU available.)

@ProfFan
Copy link
Contributor

ProfFan commented Feb 22, 2019

@elliottslaughter I think Opt is GPU only.

@Mx7f
Copy link
Contributor

Mx7f commented Mar 4, 2019

@elliottslaughter Yes, unfortunately Opt is currently without non-CUDA support. CI would be invaluable, and this limitation has come up before; so I'm seriously considering writing a small CUDA-emulation shim for the CPU (not built initially for performance) to have in Opt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants