-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added annotations to individual fields in a struct #324 #346
Conversation
Does anyone know what is broken on AppVeyor here? |
I'm not sure why AppVeyor is failing, but I'd recommend looking at the changes to |
The change in geninternalizedfile.lua makes it not syntax error when it doesn't have any lua files to internalize. The change in genclangpaths.lua makes it so that it can compile when the clang path has a space in it, for instance "C:\Program Files\Clang\clang.exe" I encountered both of these problems while trying to build from source on windows, but eventually gave up on trying to get my windows system configured to build it. Neither of them are necessary for the change I implemented, but they are improvements to the stability of the build process, I think. |
Maybe we should split those into a different PR? They seem like reasonable changes, but for this specific PR it'll be easier to debug if there's less to look at. |
Sure, I'll revert that commit and try again. |
This reverts commit c46dd1b.
That didn't magically fix it. |
Oh, please set the PR to be based on |
Oh. That could be the problem. I'll put it on master. |
Is there any chance of putting it in a good state soon? |
I don't think we're ever going to merge develop in its entirety. The parts that have been useful we've been pulling piecemeal into master. Other parts we've taken a fairly different approach on (PUC Lua support) which results in substantially less churn vs what had been done on develop. There are still some parts that would be nice to have (LLVM 3.8 debug symbols), but I haven't put in the effort to extract them. |
Closing since this is superseded by #347 (if I understand correctly---please let me know if I'm misunderstanding). |
Initial implementation of #324
Multiple comma separated annotations are not yet supported.