Skip to content

Commit

Permalink
Merge pull request #1622 from alixander/docker-go
Browse files Browse the repository at this point in the history
bump go version in docker
  • Loading branch information
alixander authored Sep 26, 2023
2 parents 436a77a + 676370d commit 5f14081
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion ci/release/build_in_docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ cd -- "$(dirname "$0")/../.."
. ./ci/sub/lib.sh

tag="$(sh_c docker build \
--build-arg GOVERSION="1.19.3.linux-$ARCH" \
--build-arg GOVERSION="1.20.8.linux-$ARCH" \
-qf ./ci/release/linux/Dockerfile ./ci/release/linux)"
docker_run \
-e DRY_RUN \
Expand Down
1 change: 0 additions & 1 deletion d2plugin/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,6 @@ func ListPluginInfos(ctx context.Context, ps []Plugin) ([]*PluginInfo, error) {
// 1. It first searches the bundled plugins in the global plugins slice.
// 2. If not found, it then searches each directory in $PATH for a binary with the name
// d2plugin-<name>.
// **NOTE** When D2 upgrades to go 1.19, remember to ignore exec.ErrDot
// 3. If such a binary is found, it builds an execPlugin in exec.go
// to get a plugin implementation around the binary and returns it.
func FindPlugin(ctx context.Context, ps []Plugin, name string) (Plugin, error) {
Expand Down

0 comments on commit 5f14081

Please sign in to comment.