Skip to content

Commit

Permalink
Update pt.terrier.Retriever __str__ and __repr__ (#474)
Browse files Browse the repository at this point in the history
  • Loading branch information
cmacdonald committed Aug 23, 2024
1 parent 1ef196d commit c663a73
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions pyterrier/terrier/retriever.py
Original file line number Diff line number Diff line change
Expand Up @@ -442,14 +442,14 @@ def _one_row(*args, **kwargs):
return res_dt

def __repr__(self):
return "BR(" + ",".join([
return "TerrierRetr(" + ",".join([
self.indexref.toString(),
str(self.controls),
str(self.properties)
]) + ")"

def __str__(self):
return "BR(" + self.controls["wmodel"] + ")"
return "TerrierRetr(" + self.controls["wmodel"] + ")"

def setControls(self, controls):
for key, value in controls.items():
Expand Down Expand Up @@ -791,7 +791,7 @@ def transform(self, queries):
return res_dt

def __repr__(self):
return "FBR(" + ",".join([
return "TerrierFeatRetr(" + ",".join([
self.indexref.toString(),
str(self.features),
str(self.controls),
Expand All @@ -800,8 +800,8 @@ def __repr__(self):

def __str__(self):
if self.wmodel is None:
return "FBR(" + str(len(self.features)) + " features)"
return "FBR(" + self.controls["wmodel"] + " and " + str(len(self.features)) + " features)"
return "TerrierFeatRetr(" + str(len(self.features)) + " features)"
return "TerrierFeatRetr(" + self.controls["wmodel"] + " and " + str(len(self.features)) + " features)"

rewrites_setup = False

Expand Down
4 changes: 2 additions & 2 deletions tests/test_experiment.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,8 @@ def test_save(self):
qrels = pt.datasets.get_dataset("vaswani").get_qrels()
df1 = pt.Experiment(brs, topics, qrels, eval_metrics=["map", "mrt"], save_dir=self.test_dir)
# check save_dir files are there
self.assertTrue(os.path.exists(os.path.join(self.test_dir, "BR(DPH).res.gz")))
self.assertTrue(os.path.exists(os.path.join(self.test_dir, "BR(BM25).res.gz")))
self.assertTrue(os.path.exists(os.path.join(self.test_dir, "TerrierRetr(DPH).res.gz")))
self.assertTrue(os.path.exists(os.path.join(self.test_dir, "TerrierRetr(BM25).res.gz")))

# check for warning
with pytest.warns(UserWarning):
Expand Down

0 comments on commit c663a73

Please sign in to comment.