Bug fix

Transformation for default mouse movement faulty due to a typo.
terrymun · May 20, 2015 · 8801d04 · 8801d04
1 parent 1ce8b93
commit 8801d04
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 12 deletions.
diff --git a/README.md b/README.md
@@ -164,3 +164,4 @@ Since Paver is provided as-is and free-of-charge, I am sorry to inform you that
 | 1.0.0   | May 14, 2015 | Official release |
 | 1.1.0   | May 16, 2015 | <p>**Code optimization**: Stored global variables and checks within the `global` variable, removed the need to pass them to individual plugin instances.</p><p>**Bug fix**:</p><ul><li>Minor fix for setTimeout and clearTimeout for scroller persistence</li><li>Added missing module of handling responsiveness of panorama when viewport is too wide</li></ul> |
 | 1.2.0   | May 19, 2015 | <p>**Better demo pages**: Demo pages have been restyled (slightly) and with navigation added.</p><p>**Feature addition**: Now you can [declare custom smoothing functions](http://terrymun.github.io/paver/demo/usage-notes.html#custom-smoothing-function). Appropriate documentations have been added/updated to reflec this new feature&mdash;and the smoothing functions documentation now comes with beautiful [d3.js](http://d3js.org/) powered graphs, and [MathJax](https://www.mathjax.org/) powered equations.</p> |
+| 1.2.1   |  | <p>**Bug fix**: Last known panned position not recorded properly.</p>
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
     "name": "paver",
-    "version": "1.2.0",
+    "version": "1.2.1",
     "description": "A minimal panorama/image viewer replicating the effect seen in Facebook Pages app.",
     "homepage": "https://github.com/terrymun/paver",
     "main": [

diff --git a/component.json b/component.json
@@ -2,7 +2,7 @@
 	"name": "paver",
 	"repo": "terrymun/paver",
 	"description": "A minimal panorama/image viewer replicating the effect seen in Facebook Pages app.",
-	"version": "1.2.0",
+	"version": "1.2.1",
 	"scripts": [
 		"./jquery.paver.js",
 		"./jqueyr.paver.min.js"

diff --git a/jquery.paver.js b/jquery.paver.js
@@ -1,6 +1,6 @@
 // Paver
 // Description: A minimal panorama/image viewer replicating the effect seen in Facebook Pages app
-// Version: 1.2.0
+// Version: 1.2.1
 // Author: Terry Mun
 // Author URI: http://terrymun.com
 ;(function ( $, window, document, undefined ) {
@@ -248,6 +248,7 @@
 
 				// Check overflow
 				if(_fun.checkOverflow(this)) {
+					console.log(paver.instanceData.lastPanX)
 					// Pan to last known position
 					paver.pan({
 						xPos: Math.min(paver.instanceData.lastPanX,1),
@@ -328,8 +329,8 @@
 
 				// Update counter and last panned position
 				paver.instanceData.panCounter += 1;
-				paver.instanceData.lastPanX = parseInt(rX);
-				paver.instanceData.lastPanY = parseInt(rY);
+				paver.instanceData.lastPanX = rX;
+				paver.instanceData.lastPanY = rY;
 			}
 		});
 
@@ -684,7 +685,7 @@
 
 				// Set transform
 				paver.pan({
-					xPos: smooth(deltaX, thresholdY),
+					xPos: smooth(deltaX, thresholdX),
 					yPos: smooth(deltaY, thresholdY)
 				});
 			}

diff --git a/jquery.paver.min.js b/jquery.paver.min.js
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "paver",
   "filename": "jquery.paver.min.js",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "A minimal panorama/image viewer replicating the effect seen in Facebook Pages app.",
   "homepage": "https://github.com/terrymun/paver",
   "main": "jquery.paver.js",

diff --git a/src/jquery.paver.js b/src/jquery.paver.js
@@ -1,6 +1,6 @@
 // Paver
 // Description: A minimal panorama/image viewer replicating the effect seen in Facebook Pages app
-// Version: 1.2.0
+// Version: 1.2.1
 // Author: Terry Mun
 // Author URI: http://terrymun.com
 ;(function ( $, window, document, undefined ) {
@@ -248,6 +248,7 @@
 
 				// Check overflow
 				if(_fun.checkOverflow(this)) {
+					console.log(paver.instanceData.lastPanX)
 					// Pan to last known position
 					paver.pan({
 						xPos: Math.min(paver.instanceData.lastPanX,1),
@@ -328,8 +329,8 @@
 
 				// Update counter and last panned position
 				paver.instanceData.panCounter += 1;
-				paver.instanceData.lastPanX = parseInt(rX);
-				paver.instanceData.lastPanY = parseInt(rY);
+				paver.instanceData.lastPanX = rX;
+				paver.instanceData.lastPanY = rY;
 			}
 		});
 
@@ -684,7 +685,7 @@
 
 				// Set transform
 				paver.pan({
-					xPos: smooth(deltaX, thresholdY),
+					xPos: smooth(deltaX, thresholdX),
 					yPos: smooth(deltaY, thresholdY)
 				});
 			}