Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ClickHouse module #944

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

smbecker
Copy link
Contributor

@smbecker smbecker commented Jul 7, 2023

What does this PR do?

This PR adds support for starting [ClickHouse] containers.

Why is it important?

This is required to write tests that target a ClickHouse database.

How to test this PR

cd tests/Testcontainers.ClickHouse.Tests
dotnet test

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit a039657
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/64ad07b2fd31c90007ec77ac
😎 Deploy Preview https://deploy-preview-944--testcontainers-dotnet.netlify.app/modules
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I will review it in the coming days. Currently, I have limited availability. The failing test is likely unrelated to the changes you made. It seems that the GitHub-hosted runner is running out of disk space due to pulling too many images. I will investigate that issue as well.

@HofmeisterAn HofmeisterAn changed the title Add support for clickhouse container feat: Add ClickHouse module Jul 11, 2023
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you once again for submitting the pull request. The module looks good.

@HofmeisterAn HofmeisterAn merged commit 5c15145 into testcontainers:develop Jul 11, 2023
9 checks passed
@HofmeisterAn HofmeisterAn added the enhancement New feature or request label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants