Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Azurite from 3.23.0 to 3.24.0 #947

Merged

Conversation

Xzelsius
Copy link
Contributor

What does this PR do?

Updates Azurite to version 3.24.0

Why is it important?

Azurite 3.24.0 is required to support Azure Storage API Version 2023-01-03

Related issues

@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 08ef18e
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/64b7b6d80fac810007508f9c
😎 Deploy Preview https://deploy-preview-947--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Xzelsius
Copy link
Contributor Author

@HofmeisterAn Do you want me to bump Azure.Storage.Blobs to 12.17.0 and Azure.Storage.Queues to 12.15.0 in this PR or in a separate one?

Azure.Storage.Blobs with version 12.17.0 has default API version 2023-01-03 thus it won't work without this PR.

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR.

@HofmeisterAn Do you want me to bump Azure.Storage.Blobs to 12.17.0 and Azure.Storage.Queues to 12.15.0 in this PR or in a separate one?

Let's bump the test dependencies together with the image version. Happy to merge the PR if the dependencies are up-to-date too. Thanks again.

FYI, typically we do not proactively update image versions unless there are changes needed in the builder configuration, such as supporting multiple major versions like MongoDB. This is to avoid introducing breaking changes. Instead, we suggest developers to select and pin the image version they prefer, giving them the freedom to decide which version to use.

@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Jul 19, 2023
@HofmeisterAn HofmeisterAn merged commit 80d078f into testcontainers:develop Jul 19, 2023
9 checks passed
@Xzelsius Xzelsius deleted the feature/bump-azurite-to-3.24.0 branch July 19, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants