fix: update wait_for_logs to not throw on 'created', and an optimization #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wait_for_logs has a mode for throwing on exit, it will now no longer treat "created" as an exit status
The status is cached on the Model instance. Without the reload, we always see the first value that was loaded.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
=======================================
Coverage ? 80.88%
=======================================
Files ? 12
Lines ? 612
Branches ? 91
=======================================
Hits ? 495
Misses ? 90
Partials ? 27 ☔ View full report in Codecov by Sentry. |
alexanderankin
changed the title
alexanderankin
changed the title
alexanderankin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix another part of #715 , plus an optimization.
Based on #716 by @alexanderankin .