Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update wait_for_logs to not throw on 'created', and an optimization #719

Merged
merged 3 commits into from
Oct 24, 2024
Merged

fix: update wait_for_logs to not throw on 'created', and an optimization #719

merged 3 commits into from
Oct 24, 2024

Commits on Oct 16, 2024

  1. fix: update wait_for_logs to not throw on "created" 

    wait_for_logs has a mode for throwing on exit, it will now no longer treat "created" as an exit status
    @alexanderankin
    alexanderankin committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    deb6a6a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. fix(core): Reload container in wait_for_logs before checking status 

    The status is cached on the Model instance. Without the reload, we
always see the first value that was loaded.
    @mschmitzer
    mschmitzer committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    08bf23f View commit details
    Browse the repository at this point in the history

  2. fix(core): Don't call "logs" twice in wait_for_logs

    @mschmitzer
    mschmitzer committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    e2631d5 View commit details
    Browse the repository at this point in the history