Skip to content

chore: copy-to-container interface improvements (#732) #1153

chore: copy-to-container interface improvements (#732)

chore: copy-to-container interface improvements (#732) #1153

Triggered via push September 13, 2024 19:28
Status Success
Total duration 5m 47s
Artifacts

ci.yml

on: push
Build with MSRV
1m 33s
Build with MSRV
Rustfmt check
14s
Rustfmt check
PR name check
0s
PR name check
Matrix: Clippy check
Matrix: Test
Fit to window
Zoom out
Zoom in

Annotations

16 warnings
Rustfmt check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Rustfmt check
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Rustfmt check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Rustfmt check
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
this manual char comparison can be written more succinctly: testcontainers/src/core/logs/consumer/logging_consumer.rs#L47
warning: this manual char comparison can be written more succinctly --> testcontainers/src/core/logs/consumer/logging_consumer.rs:47:48 | 47 | let message = message.trim_end_matches(|c| c == '\n' || c == '\r'); | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['\n', '\r']` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default
the borrowed expression implements the required traits: testimages/build.rs#L27
warning: the borrowed expression implements the required traits --> testimages/build.rs:27:14 | 27 | .arg(&format!( | ______________^ 28 | | "{cwd}/src/dockerfiles/simple_web_server.dockerfile" 29 | | )) | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args help: change this to | 27 ~ .arg(format!( 28 + "{cwd}/src/dockerfiles/simple_web_server.dockerfile" 29 ~ )) |
the borrowed expression implements the required traits: testimages/build.rs#L12
warning: the borrowed expression implements the required traits --> testimages/build.rs:12:14 | 12 | .arg(&format!("{cwd}/src/dockerfiles/no_expose_port.dockerfile")) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{cwd}/src/dockerfiles/no_expose_port.dockerfile")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
Clippy check (nightly)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy check (nightly)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
this manual char comparison can be written more succinctly: testcontainers/src/core/logs/consumer/logging_consumer.rs#L47
warning: this manual char comparison can be written more succinctly --> testcontainers/src/core/logs/consumer/logging_consumer.rs:47:48 | 47 | let message = message.trim_end_matches(|c| c == '\n' || c == '\r'); | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using an array of `char`: `['\n', '\r']` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_pattern_char_comparison = note: `#[warn(clippy::manual_pattern_char_comparison)]` on by default
the borrowed expression implements the required traits: testimages/build.rs#L27
warning: the borrowed expression implements the required traits --> testimages/build.rs:27:14 | 27 | .arg(&format!( | ______________^ 28 | | "{cwd}/src/dockerfiles/simple_web_server.dockerfile" 29 | | )) | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args help: change this to | 27 ~ .arg(format!( 28 + "{cwd}/src/dockerfiles/simple_web_server.dockerfile" 29 ~ )) |
the borrowed expression implements the required traits: testimages/build.rs#L12
warning: the borrowed expression implements the required traits --> testimages/build.rs:12:14 | 12 | .arg(&format!("{cwd}/src/dockerfiles/no_expose_port.dockerfile")) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("{cwd}/src/dockerfiles/no_expose_port.dockerfile")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
Clippy check (stable)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Clippy check (stable)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/