Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention testcontainers-modules #523

Merged

Conversation

DDtKey
Copy link
Collaborator

@DDtKey DDtKey commented Sep 25, 2023

It would be nice to mention the new location of ready-to-use images, because of #471

It will helpful for users once 0.15.0 is released.

@DDtKey DDtKey mentioned this pull request Sep 25, 2023
Copy link
Collaborator

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can you fix that outdated doc line while we are at it?

testcontainers/src/lib.rs Outdated Show resolved Hide resolved
It would be nice to mention the new location of ready-to-use images, because of testcontainers#471

It will helpful for users once `0.15.0` is released.
@thomaseizinger
Copy link
Collaborator

@DDtKey The README also still points at the integration tests. Mind pointing towards the modules instead?

@DDtKey DDtKey force-pushed the add-info-of-community-modules branch from f830d0e to 812619d Compare September 27, 2023 09:02
@DDtKey
Copy link
Collaborator Author

DDtKey commented Sep 27, 2023

It makes sense to me, I've updated the readme to include 2 sections:

  1. How to use testcontainers directly
  2. Reference to the ready-to-use modules

Please check if it sounds good to you

Copy link
Collaborator

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@thomaseizinger thomaseizinger added this pull request to the merge queue Sep 28, 2023
Merged via the queue into testcontainers:dev with commit 8c89718 Sep 28, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants