refactor: replace dirs crate with etcetera #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Joonas Bergius <joonas@bergi.us>
joonas
force-pushed
the
joonas/replace-dirs-with-etcetera
branch
from
4c138b3
to
3e67b9a
Compare
joonas
changed the title
dirs dependency with etcetera
DDtKey
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
That's really a good catch!
Thank you 🚀
I find this reasonable and probably we should consider usage cargo-about in CI to prevent accidental usage
This was referenced Sep 25, 2024
Closed
Merged
DDtKey
pushed a commit
that referenced
this pull request
Sep 25, 2024
## 🤖 New release * `testcontainers`: 0.22.0 -> 0.23.0 (⚠️ API breaking changes) ###⚠️ `testcontainers` breaking changes ``` --- failure enum_variant_added: enum variant added on exhaustive enum --- Description: A publicly-visible enum without #[non_exhaustive] has a new variant. ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_variant_added.ron Failed in: variant ClientError:UploadToContainerError in /tmp/.tmpnaUdoG/testcontainers-rs/testcontainers/src/core/client.rs:92 variant ClientError:CopyToContainerError in /tmp/.tmpnaUdoG/testcontainers-rs/testcontainers/src/core/client.rs:94 --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/trait_method_added.ron Failed in: trait method testcontainers::core::ImageExt::with_copy_to in file /tmp/.tmpnaUdoG/testcontainers-rs/testcontainers/src/core/image/image_ext.rs:62 trait method testcontainers::ImageExt::with_copy_to in file /tmp/.tmpnaUdoG/testcontainers-rs/testcontainers/src/core/image/image_ext.rs:62 ``` <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.23.0] - 2024-09-25 ### Details #### Bug Fixes - Expose public `copy` types ([#734](#734)) - Typo in an error variant ([#738](#738)) #### Features - Support copy files to container ([#730](#730)) - Support copying directories to container ([#735](#735)) #### Miscellaneous Tasks - Copy-to-container interface improvements ([#732](#732)) #### Refactor - Replace dirs crate with etcetera ([#736](#736)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently learned that
dirsdepends onoption-extviadir-sys(as ofdir-sys0.4.1 that came in as part ofdirs5.0.1), which is MPL 2.0 licensed.It does not appear that the author is interested reconsidering their stance on licensing, which unfortunately creates some complications for projects under the CNCF umbrella (as well as many corporate projects), and so I thought I would propose switching
dirsout foretceterasince it is MIT or Apache 2.0 licensed.As you can see from the linked thread, this is a fairly common limitation for adoption, so in the interest of enabling further adoption, I believe it would be in the best interest for
testcontainers-rsto reconsider this dependency, especially considering how trivial it is to replace 🙂FWIW, I have done testing on my end to ensure that the changes I'm proposing produce similar results under Mac OS and Linux, but since I don't have direct access to Windows I can't say with 100% certainty that they do though from reading through the code across both libraries, I feel fairly confident that they should.