-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Convert rvgo's memory implementation to radix trie #6
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
==========================================
+ Coverage 72.30% 73.08% +0.77%
==========================================
Files 16 17 +1
Lines 2723 2913 +190
==========================================
+ Hits 1969 2129 +160
- Misses 670 689 +19
- Partials 84 95 +11 ☔ View full report in Codecov by Sentry. |
123e78b
to
a9204b4
Compare
a44e2be
to
65c35f2
Compare
65c35f2
to
4b88e18
Compare
a1ff36e
to
89460e6
Compare
// InvalidateNode invalidates the hash cache along the path to the specified address. | ||
InvalidateNode(addr uint64) | ||
// GenerateProof generates the Merkle proof for the given address. | ||
GenerateProof(addr uint64) [][32]byte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could add a slice as argument, to append the result to, and then return the updated slice header. Then you can allocate a slice with the capacity of the expected proof size once, and write to that in each proof level, to prevent allocations.
Closing in favor of ethereum-optimism#83 |
No description provided.