Merge branch 'main' into rings

teunbrand · Apr 27, 2024 · 0e6db0a · 0e6db0a
2 parents 76e9801 + a7eec4a
commit 0e6db0a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -2,6 +2,10 @@
 
 Restarted package from scratch, using a different approach.
 
+Thanks to the following people for catching and reporting early bugs:
+
+* @davidhodge931 (#7, #8, #9)
+
 ## Mechanism
 
 The crux in gguidance is that you combine a 'key', that contains instructions

diff --git a/R/primitive-ticks.R b/R/primitive-ticks.R
@@ -199,7 +199,7 @@ PrimitiveTicks <- ggproto(
 
 draw_ticks = function(key, element, params, position, length, offset = 0) {
   n_breaks <- nrow(key)
-  if (n_breaks < 1 || is_blank(element) || length == 0) {
+  if (n_breaks < 1 || is_blank(element) || all(length == 0)) {
     return(zeroGrob())
   }
   bidi <- c(1, -as.numeric(params$bidi %||% FALSE))