fix(auth): log auth error properly (#2823)

tf2pickup-org · Apr 20, 2024 · 83cb62a · 83cb62a
1 parent 4d714c8
commit 83cb62a
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/auth/controllers/auth.controller.ts b/src/auth/controllers/auth.controller.ts
@@ -36,7 +36,7 @@ export class AuthController {
         // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-call
         return passport.authenticate(
           'steam',
-          (error: Error, player: Player) => {
+          (error: unknown, player: Player) => {
             let url = this.environment.clientUrl;
             if (req.headers.cookie) {
               const cookies = parse(req.headers.cookie);
@@ -49,7 +49,14 @@ export class AuthController {
             }
 
             if (error) {
-              this.logger.warn(`Login error: ${error.message}`);
+              if (error instanceof Error) {
+                this.logger.warn(`Login error: ${error.message}`);
+              } else if (typeof error === 'string') {
+                this.logger.warn(`Login error: ${error}`);
+              } else {
+                this.logger.warn(`Login error: ${JSON.stringify(error)}`);
+              }
+
               const clientErrorCode = this.mapToClientError(error);
               return res.redirect(`${url}/auth-error?error=${clientErrorCode}`);
             }