Optimize analysis calculation #495
Merged
+39
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aggregating analyzed results is slow for complex expressions because we aggregate samples over and over again. This commit speeds that up by memoizing aggregates. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
fix-slow-analysis
branch
from
2c4b1ee
to
edddb3c
Compare
logicalplan/distribute.go
Outdated
Comment on lines
201
to
203
| sum := *(*current).(*Aggregation) | ||
| sum := *(*current).Clone().(*Aggregation) | ||
| sum.Op = parser.SUM | ||
| count := *(*current).(*Aggregation) | ||
| count := *(*current).Clone().(*Aggregation) |
There was a problem hiding this comment.
Good catch, reverted.
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
MichaHoffmann
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aggregating analyzed results is slow for complex expressions because we aggregate samples over and over again.
This commit speeds that up by memoizing aggregates.